Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alt text to the Canada Wordmark #91

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Conversation

smcmurtry
Copy link
Contributor

@smcmurtry smcmurtry commented Jul 9, 2021

Summary | Résumé

I will convert from draft after I fix the tests. Fixed

I noticed that there was no alt text for the Canada wordmark inserted at the bottom of Notify emails, so screen readers read nothing for this. I looked at Canada.ca and copied the english and french alt text from there:

Screen Shot 2021-07-09 at 4 31 26 PM

Screen Shot 2021-07-09 at 4 33 37 PM

@smcmurtry smcmurtry changed the title Added alt text to the canada wordmark Added alt text to the Canada Wordmark Jul 9, 2021
@smcmurtry smcmurtry marked this pull request as draft July 9, 2021 20:49
@smcmurtry smcmurtry marked this pull request as ready for review July 12, 2021 13:24
@smcmurtry
Copy link
Contributor Author

@smcmurtry smcmurtry added the a11y Accessibility label Jul 12, 2021
Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smcmurtry smcmurtry merged commit 00d4023 into master Jul 12, 2021
@smcmurtry smcmurtry deleted the patch/wordmark-alt-text branch July 12, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants