Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Add a prod version environment variable #1444

Closed
sastels opened this issue Feb 19, 2020 · 0 comments · Fixed by #1656
Closed

Add a prod version environment variable #1444

sastels opened this issue Feb 19, 2020 · 0 comments · Fixed by #1656
Assignees
@sastels
Labels
medium priority not high, not low, but medium!

Comments

@sastels
Copy link
Contributor

sastels commented Feb 19, 2020

Summary

Have a sensible version number for prod

Design Detail

Add REACT_APP_PROD_VERSION
Use this in the version along with the gitSha. Something like
Version: 1.0.0 (a2ef182)

Unresolved questions

Shall we stick to semantic versioning? What would be a major version in that case? Some sort of significant milestone?
@sastels sastels added needs prioritization We have to prioritize this issue medium priority not high, not low, but medium! and removed needs prioritization We have to prioritize this issue labels Feb 19, 2020
@sastels sastels self-assigned this Mar 10, 2020
@sastels sastels mentioned this issue Mar 10, 2020
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sastels sastels

Labels
medium priority not high, not low, but medium!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prod version number cds-snc/report-a-cybercrime
1 participant
@sastels