This repository has been archived by the owner on May 7, 2021. It is now read-only.
Prod version number #1656
Merged
Prod version number #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidheerema
suggested changes
Mar 11, 2020
You shouldn't have to add anything for this - at least, the way I've done it here the values are hard coded in everywhere (and are just needed in the pipeline / docker build, not in App Service) |
|
Oh yes, I see that. My mistake thanks.
…On Wed, Mar 11, 2020 at 12:38 PM Steve Astels ***@***.***> wrote:
This looks good to me Steve.
*Please inform me when this is merged so that I can add the new
environment variable to every environment*
You shouldn't have to add anything for this - at least, the way I've done
it here the values are hard coded in everywhere (and are just needed in the
pipeline / docker build, not in App Service)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1656 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMK4IC6R7JDAKHFEJI7YLMDRG65BXANCNFSM4LFHHDVQ>
.
|
|
I think this is probably the wrong way to do this... if we're going to hard code the version # anyway, we should just hard code it in the app code directly. I shall fix up... Done! |
sastels
dismissed
davidheerema’s stale review
rewrote code - should have a new review
sastels
added a commit
that referenced
this pull request
Mar 19, 2020
* Minor copy change (typo) (#1639) * extract data from formidable manually (#1641) * fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632) * fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642) * Fix for Logs in another Azure Subscription (#1619) * Updating IMAGE_NAME reference (#1597) * change GNCC to GNC3 (#1655) * use redirect for equifax links (#1651) * clear file input after alert (#1662) * fix keyboard nav (#1660) * add moneyLost.methodOther field to analyst report (#1647) * more detailed p and text stories (#1643) * added stuff to sb docs (#1671) * added getting started page to storybook (#1661) * FIX CORS for HTTPS (#1665) (#1669) * clean up logging a bit (#1663) * tweak skiplink style (#1658) * fix target area for upload button (#1653) * change "go back" button's height to the same height as "cancel report" button (#1666) * added Messages component. (#1644) * fix: upgrade async from 3.1.1 to 3.2.0 (#1680) * Reports a day counter (#1664) * Form validation - bump (#1510) * added helmet in server.js (#1674) * Combine analyst emails (#1628) * Prod version number (#1656) * Fixed Field, added container and layout to sb (#1675) * Get email addresses from ldap query (#1682) * restrict file number and size on server (#1648) * remove submit button if already submitted (#1683) * Fix for Continuous Deployment (#1690) * Validation for location fields (#1689) * cypress pack initial commit (#1247)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1444
Description
Add a version number of the form 1.0.0 (in addition to the gitsha that is currently there).
Checklist: