Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

extract data from formidable manually #1641

Merged
merged 1 commit into from
Mar 9, 2020
Merged

extract data from formidable manually #1641

merged 1 commit into from
Mar 9, 2020

Conversation

sastels
Copy link
Contributor

@sastels sastels commented Mar 6, 2020

Fixes #1638

Description

Use formidable to manually extract the form data rather than all in one go. This lets us extract files with the same name without losing any.

Checklist:

  • I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)
  • I have added and needed tests for my changes (in particular for new screens)
  • I have added a comment to any confusing code

@sastels sastels temporarily deployed to rac-prototyp-same-name-p0z4vbh March 6, 2020 21:59 Inactive
@sastels sastels requested a review from ngosset March 6, 2020 22:08
Copy link
Contributor

@ngosset ngosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels merged commit 9ec975f into master Mar 9, 2020
@sastels sastels deleted the same-name-files branch March 9, 2020 18:57
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receive only one attachment if the user send 2 files which have the same name but different content
2 participants