-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
e94f8c5
to
538b7ce
Compare
…get-emails-from-hermis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I tagged a comment inline for a typo.
-
I configured my vars to list mine and norm hrmis id. The following is the output. I received an email ONE email containing the attachment and the report all in one
Maryses-MacBook-Air:f2 david$ node server.js
Availability configured
Self harm word list: aspenite
Notify client created
Listening at port 3000
(node:4277) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.
ldapQuery: Certificate for Norman.Gosset@rcmp-grc.gc.ca (000146484) found
ldapQuery: Certificate for david.heerema@rcmp-grc.gc.ca (000111621) found
LDAP certs successfully fetchedfetched for: david.heerema@rcmp-grc.gc.ca,Norman.Gosset@rcmp-grc.gc.ca
Encrypted Mail: Message encrypted
Encrypted Mail: Message encrypted
Created container ncfrsw1hrkr7skc5 successfully
Report NCFRS-w1hrkr7skc5 saved to CosmosDB
Encrypted Mail: Message sent to david.heerema@rcmp-grc.gc.ca: 2f7f4c83-40bd-aee4-c1c1-fd9967df33f3@racc.m.notification.alpha.canada.ca
Uploaded report NCFRS-w1hrkr7skc5 file Screen Shot 2020-03-13 at 10.07.16 AM.png, blob bf24aa890c70a80ec5e33ed62887642f749c54ea successfully
Encrypted Mail: Message sent to Norman.Gosset@rcmp-grc.gc.ca: a25dded0-6e7a-ff2d-74f2-a8b5e425fb6a@racc.m.notification.alpha.canada.ca
f2/server.js
Outdated
uidListInitial.length === uidList.length && | ||
uidListInitial.length === emailList.length | ||
) | ||
console.log(`LDAP certs successfully fetchedfetched for: ${emailList}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here.
Once norm confirms he received the email as well I can approve my review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kevin received a test report so this PR looks good.
* Minor copy change (typo) (#1639) * extract data from formidable manually (#1641) * fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632) * fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642) * Fix for Logs in another Azure Subscription (#1619) * Updating IMAGE_NAME reference (#1597) * change GNCC to GNC3 (#1655) * use redirect for equifax links (#1651) * clear file input after alert (#1662) * fix keyboard nav (#1660) * add moneyLost.methodOther field to analyst report (#1647) * more detailed p and text stories (#1643) * added stuff to sb docs (#1671) * added getting started page to storybook (#1661) * FIX CORS for HTTPS (#1665) (#1669) * clean up logging a bit (#1663) * tweak skiplink style (#1658) * fix target area for upload button (#1653) * change "go back" button's height to the same height as "cancel report" button (#1666) * added Messages component. (#1644) * fix: upgrade async from 3.1.1 to 3.2.0 (#1680) * Reports a day counter (#1664) * Form validation - bump (#1510) * added helmet in server.js (#1674) * Combine analyst emails (#1628) * Prod version number (#1656) * Fixed Field, added container and layout to sb (#1675) * Get email addresses from ldap query (#1682) * restrict file number and size on server (#1648) * remove submit button if already submitted (#1683) * Fix for Continuous Deployment (#1690) * Validation for location fields (#1689) * cypress pack initial commit (#1247)
Fixes #1633
Description
Instead of having the email addresses in an environment variable, get them from the ldap query that we use to get the cert.
Checklist: