Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

more detailed p and text stories #1643

Merged
merged 9 commits into from
Mar 13, 2020
Merged

more detailed p and text stories #1643

merged 9 commits into from
Mar 13, 2020

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Mar 9, 2020

Description

Added more details in the P and Text stories.

Modified the PR template to include updating the documentation.

Checklist:

  • I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)
  • I have added and needed tests for my changes (in particular for new screens)
  • I have added a comment to any confusing code

@amazingphilippe amazingphilippe added the documentation Things related with documenting the codebase. Like storybook label Mar 9, 2020
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 9, 2020 14:33 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 9, 2020 14:33 Inactive
@@ -17,6 +17,8 @@ The text component can be used to wrap text when no wrapper is available

You have access to any [Chakra UI Text](https://chakra-ui.com/text) properties like `fontSize`

`<Text>` does not have spacing. This is useful when you don't want to use a `<P>` element. However, you can create spacing by making use of the [Chakra UI Stack](https://chakra-ui.com/stack) element
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

period at the end probably.

Copy link
Contributor

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, LGTM

@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 10, 2020 20:18 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 10, 2020 20:22 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 10, 2020 20:25 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 12, 2020 15:10 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 13, 2020 14:40 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-jzxl2br March 13, 2020 17:44 Inactive
@amazingphilippe amazingphilippe merged commit ba03823 into master Mar 13, 2020
@amazingphilippe amazingphilippe deleted the storybook-p-text branch March 13, 2020 17:47
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Things related with documenting the codebase. Like storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants