Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Fixed Field, added container and layout to sb #1675

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Mar 13, 2020

Fixes #1676

Documentation

Description

Added:

  • Field
  • Layout
  • Container

Checklist:

  • I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)
  • I have added and needed tests for my changes (in particular for new screens)
  • I have added a comment to any confusing code
  • I have added documentation to any modified front-end code. (Or added missing documentation)

@amazingphilippe amazingphilippe added the documentation Things related with documenting the codebase. Like storybook label Mar 13, 2020
@amazingphilippe amazingphilippe mentioned this pull request Mar 17, 2020
4 tasks
@sastels sastels temporarily deployed to rac-prototyp-sb-layout-4zjx489 March 17, 2020 20:07 Inactive
@sastels sastels temporarily deployed to rac-prototyp-sb-layout-4zjx489 March 17, 2020 20:10 Inactive
@DianeLiu2019 DianeLiu2019 self-requested a review March 17, 2020 21:14
@sastels sastels temporarily deployed to rac-prototyp-sb-layout-4zjx489 March 17, 2020 21:15 Inactive
@amazingphilippe amazingphilippe merged commit 01261ba into master Mar 18, 2020
@amazingphilippe amazingphilippe deleted the sb-layout-containers-fields branch March 18, 2020 12:40
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Things related with documenting the codebase. Like storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Field" components cause storybook error
3 participants