Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

added Messages component. #1644

Merged
merged 6 commits into from
Mar 16, 2020
Merged

added Messages component. #1644

merged 6 commits into from
Mar 16, 2020

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Mar 9, 2020

Fixes #1456

Description

Exports different message types: alerts and wells.

Changelist:

  • Added a component
  • Added a story and tests for the component
  • Modified pages that contained <Alerts> in a way where they were not needed

Required followup work

  • Needs a test
  • Going through app and making sure we are using messages correctly.

Checklist:

  • I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)
  • I have added and needed tests for my changes (in particular for new screens)
  • I have added a comment to any confusing code

@sastels sastels temporarily deployed to rac-prototyp-uifix-aler-abdnpo March 9, 2020 19:57 Inactive
@sastels sastels temporarily deployed to rac-prototyp-uifix-aler-abdnpo March 10, 2020 15:27 Inactive
@sastels sastels temporarily deployed to rac-prototyp-uifix-aler-abdnpo March 10, 2020 16:45 Inactive
@amazingphilippe amazingphilippe marked this pull request as ready for review March 10, 2020 17:59
@sastels sastels temporarily deployed to rac-prototyp-uifix-aler-y5ke9u March 16, 2020 14:13 Inactive
Copy link
Contributor

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this going to conflict with the validation changes in #1510 ?

@amazingphilippe
Copy link
Contributor Author

amazingphilippe commented Mar 16, 2020

Is this going to conflict with the validation changes in #1510 ?

Might cause some issues on pages with validation. Easy conflicts tho. 🤞 👀

Also I think its better to merge this one first

@sastels sastels temporarily deployed to rac-prototyp-uifix-aler-y5ke9u March 16, 2020 15:24 Inactive
@amazingphilippe amazingphilippe merged commit 388dbad into master Mar 16, 2020
@amazingphilippe amazingphilippe deleted the uifix-alerts branch March 16, 2020 15:32
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign information tip/alert box
2 participants