Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

cypress pack initial commit #1247

Merged
merged 90 commits into from
Mar 19, 2020
Merged

cypress pack initial commit #1247

merged 90 commits into from
Mar 19, 2020

Conversation

khalidelaggan
Copy link
Contributor

No description provided.

@khalidelaggan khalidelaggan temporarily deployed to rac-prototyp-cypress-0ijz715gs January 31, 2020 10:26 Inactive
@khalidelaggan khalidelaggan temporarily deployed to rac-prototyp-cypress-0ijz715gs January 31, 2020 14:48 Inactive
@khalidelaggan khalidelaggan changed the title [WIP] cypress pack initial commit cypress pack initial commit Mar 18, 2020
env:
CI: true
NODE_ENV: testing
A11Y_TRACKER_KEY: ${{ secrets.A11Y_TRACKER_KEY }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need to figure out adding this to the secret

@khalidelaggan
Copy link
Contributor Author

@sastels @maxneuvians ready to review and address any comments 👍

@sastels
Copy link
Contributor

sastels commented Mar 19, 2020

Running locally with npm run cypress then clicking "run all specs" I get two test failures

image

npm run cypress:cli succeeds though 🎉

@sastels
Copy link
Contributor

sastels commented Mar 19, 2020

The file cypress/videos/examples/aliasing.spec.js.mp4 gets deleted when I run npm run cypress:cli - should it be in there?

Copy link
Contributor

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! will be nice to get this in the repo add a few more smoke tests 👍

Just swap out those images and delete that video and we're good to go!

Copy link
Contributor

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khalidelaggan
Copy link
Contributor Author

Running locally with npm run cypress then clicking "run all specs" I get two test failures

image

npm run cypress:cli succeeds though 🎉

Yes! as the test that Hong written needs to be adjusted slightly to the changes in Staging, it will be a perfect exercise to show the team ins the outs of tests workflow that aren't aligned with code changes :)

@khalidelaggan
Copy link
Contributor Author

Looks good! will be nice to get this in the repo add a few more smoke tests 👍

Just swap out those images and delete that video and we're good to go!

Excellent! more tests to be merged today for sure!

@khalidelaggan
Copy link
Contributor Author

Happy this is being merged, so we can broaden writing tests with more participant now.

@khalidelaggan khalidelaggan merged commit 9650471 into master Mar 19, 2020
@khalidelaggan khalidelaggan deleted the cypress branch March 19, 2020 14:24
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants