Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

added getting started page to storybook #1661

Merged
merged 5 commits into from
Mar 13, 2020
Merged

Conversation

amazingphilippe
Copy link
Contributor

Description

Documentation

Added a getting started page for reference

Removed Knobs for now. Cuasing issues with MDX. MDX comes with greater advantages than knobs.

Required followup work

More documentation!

Checklist:

  • I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)
  • I have added and needed tests for my changes (in particular for new screens)
  • I have added a comment to any confusing code

@sastels sastels temporarily deployed to rac-prototyp-storybook-hytbpg3 March 11, 2020 18:54 Inactive
@sastels sastels temporarily deployed to rac-prototyp-storybook-hytbpg3 March 11, 2020 20:02 Inactive
@amazingphilippe amazingphilippe added the documentation Things related with documenting the codebase. Like storybook label Mar 11, 2020
@sastels sastels temporarily deployed to rac-prototyp-storybook-hytbpg3 March 13, 2020 17:39 Inactive
Copy link
Contributor

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just finish that sentence :)


## Component variations

If a component is missing, it has not been documented. You can create a Github issue to request that someone document the missing component, or you can create the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave me hanging! :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! I'm on it, basically, this is for the

@sastels sastels temporarily deployed to rac-prototyp-storybook-hytbpg3 March 13, 2020 18:29 Inactive
@amazingphilippe amazingphilippe merged commit a9965b6 into master Mar 13, 2020
@amazingphilippe amazingphilippe deleted the storybook-start branch March 13, 2020 19:01
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Things related with documenting the codebase. Like storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants