Resolves #3, resolves #4, resolves #5 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ The issue with the DLL shared symbols extraction is now resolved.
The remedy was to remove the ` && !defined CFI_ENABLED` from all
instances of the intel DLLEXPORT statements.
+ Several procedures lacked DLLEXPORT statements which are now corrected.
+ The ossasional file locking by Windows in multichain parallel mode in
ParaDRAM and ParaDISE algorithms is now resolved. The remedy was to add
`SHARED` argument to all `open` statements in the library.
Previously, only a select number of `open` statements had this
Intel argument. Note that this is an extension by the Intel compiler and
is only activated when Intel compiler is used, exclusively on Windows.
Outstanding issues:
+ There still seems to exist some issues with the sampler tests in parallel on Windows.
The underlying reason "could" be potential differences in the preprocessor flag definitions
between Windows and Linux.
The build script used to detect the local installation and copy the setup file to the installation directory, regardless of whether the local installation were being used. This problem is now resolved and the setup file is copied to the installation directory only when the local MPI library or compilers are used to build the library.
This now avoids the improper exit from the test on macOS, which used to create exit 1 error status code, leading to a reinstallation of MPI request with every ParaMonte installation attempt despite the fact that MPI had been already properly installed on the system. Merge branch 'dev' of github.com:cdslaborg/paramonte into dev
The kernel documentation errors are now resolved. The ParaDRAM class in Python is now also accessible as `Paradram` and `paradram`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #3, issue #4, and issue #5 raised by @milancurcic. The lastest kernel code coverage tests are available to view at,