Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning where needed #226

Open
degremont opened this issue Feb 2, 2014 · 5 comments
Open

Add deprecation warning where needed #226

degremont opened this issue Feb 2, 2014 · 5 comments
Milestone

Comments

@degremont
Copy link
Collaborator

A couple of method and classes are deprecated in ClusterShell.
We need to add call to warnings.warn where needed.

The next release will be able to drop this code.

@thiell thiell added this to the 1.8 milestone Mar 22, 2015
@degremont
Copy link
Collaborator Author

Partially done by #271

@thiell
Copy link
Collaborator

thiell commented Sep 17, 2017

What remaining methods/classes have to be deprecated in 1.8?

@degremont
Copy link
Collaborator Author

degremont commented Sep 18, 2017

Maybe current code is enough, I'm listing some deprecated features here:

  • Already done?

    • Worker.last_*() (1.6)
  • Don't know how to do with symbol/aliases

    • NodeSet.STD_GROUP_RESOLVER (1.5)
    • NodeSet.NOGROUP_RESOLVER (1.5)
    • WorkerBadArgumentError (1.4)
  • TODO

    • topology.conf: Main section (1.7)
    • GroupResolver.set_verbosity() (1.7)
  • Not yet

    • WorkerSimple (1.7, still used by WorkerOpen (as of 1.8))
    • Old EventHandler prototypes (1.8)

@thiell
Copy link
Collaborator

thiell commented Oct 3, 2017

Thx. Sounds good to me.

I say we remove the first two in 2.0.

There is no rush for the TODO items. Let's do that later.

Let's work on getting rid of WorkerSimple in 1.9 as much as possible, so we can remove it in 2.0.

@thiell thiell modified the milestones: 1.8, 1.9 Oct 3, 2017
thiell added a commit to thiell/clustershell that referenced this issue Nov 23, 2022
Remove deprecated methods:
- Worker.last_error()
- Worker.last_node()
- Worker.last_read()
- Worker.last_retcode()

They have been deprecated since at least v1.6.
thiell added a commit that referenced this issue Nov 23, 2022
Remove deprecated methods:
- Worker.last_error()
- Worker.last_node()
- Worker.last_read()
- Worker.last_retcode()

They have been deprecated since at least v1.6.
@thiell thiell modified the milestones: 1.9, 1.10 Nov 23, 2022
@thiell
Copy link
Collaborator

thiell commented Nov 24, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants