Fix for python-3.10 #484
Merged
Fix for python-3.10 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by using current_thread() and notify_all() instead of the deprecated currentThread() and notifyAll() functions. This fixes DeprecationWarnings from the test suite that end up as errors. AFAICT, the new names have been available since python-2.6[1], so this change should not break support for any current python versions. [1] https://docs.python.org/2.6/library/threading.html#threading.current_thread https://docs.python.org/2.6/library/threading.html#threading.Condition.notify_all
|
The latest https://github.com/nixos/nixpkgs/ defaults to python-3.10 (which means clustershell is currently broken), so landing this PR and making a release would be appreciated :-) |
thiell
approved these changes
Aug 8, 2022
|
@bjornfor thanks much! it's good timing as we'll release version 1.9 soon. It will include these fixes for Python 3.10. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by using current_thread() and notify_all() instead of the deprecated
currentThread() and notifyAll() functions. This fixes
DeprecationWarnings from the test suite that end up as errors.
AFAICT, the new names have been available since python-2.6[1], so this
change should not break support for any current python versions.
[1] https://docs.python.org/2.6/library/threading.html#threading.current_thread
https://docs.python.org/2.6/library/threading.html#threading.Condition.notify_all