Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord permissions system example #145
Discord permissions system example #145
Changes from all commits
c01ec20
3bda1a5
4472038
f1f0366
cda0c7f
6bd9dc4
d5590fd
821dd67
6d16748
fdb1e73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really the case that Discord makes users specific to a channel? Or is this a modeling artifact?
If the latter, can we model this more simply without the entity hierarchy and channel-specific users as follows. Each user has an attribute
channelRoles : Set<{channel : Channel, role : String}>
. Then, to check if the user has “SendMessage” role, we write:Would this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you've pointed out the problem: users should not be channel-specific.
Unfortunately, your cedar rule won't work because it drops the
principal.channel_roles in Allow::"SendMessage"
line. What this rule needs is a map from channels toChannelRoles
so that we can perform this lookup. (see the comment in theUser
entity)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the problem is that the permissions need to be transitively inherited. In that case, you'd have to keep the transitive closure of the reachable roles / channels in this attribute, which is clunky and defeats the point of using Cedar.