cedar wasm example #163
Merged
cedar wasm example #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khieta
reviewed
Jun 20, 2024
There was a problem hiding this comment.
So cool! Thanks for the contribution! I think this will be really useful for consumers of the Wasm code. And once we get CI set up, it will help our team avoid unintentionally breaking the Wasm bindings 🙂
Could you add a README with instructions on how to build & run tests?
Swolebrain
force-pushed
the
main
branch
2 times, most recently
from
ba1b3f8
to
ac80bab
Compare
Signed-off-by: Victor Moreno <morevct@amazon.com>
andrewmwells-amazon
approved these changes
Jun 20, 2024
|
Build failure is unrelated. |
shaobo-he-aws
approved these changes
Jun 20, 2024
|
Downstram failure is unrelated (fixed in cedar-policy/cedar#1015) |
khieta
pushed a commit
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Victor Moreno <morevct@amazon.com> Co-authored-by: Victor Moreno <morevct@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
adds a wasm example