Updates for cedar-policy/cedar#1026 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a unit test for `get_lists` Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
requested review from
khieta,
cdisselkoen,
aaronjeline,
andrewmwells-amazon and
john-h-kastner-aws
cdisselkoen
approved these changes
Jun 26, 2024
john-h-kastner-aws
approved these changes
Jun 26, 2024
|
looks like list order is not deterministic for that test. (or maybe you just got the order wrong lol) |
Good catch. Fixing it. |
andrewmwells-amazon
approved these changes
Jun 26, 2024
shaobo-he-aws
added a commit
that referenced
this pull request
Jun 27, 2024
This reverts commit bc43f56.
shaobo-he-aws
added a commit
that referenced
this pull request
Jun 27, 2024
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a unit test for
get_listsIssue #, if available:
Description of changes: