refactor oopsla2024-benchmarks #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a major refactoring of the OOPSLA benchmark code. The previous structure was (IMO) difficult to navigate, and included several unnecessary files. For a summary of the new structure, see the addition to the benchmark folder's README.
This PR is primarily just renaming & deleting files, but there are two (sort of) substantive changes:
validate_all_benchmarks.shscript.rego-harnessfolder instead of leaving it nested intinytodo.Note that users can still access the benchmarking code in its original form on the
release/3.1.xbranch.I'm also planning to bump the version of Cedar used to 4.0.0, but that will come in a future PR.