enable errcheck for the project and fix the violations discovered #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Jakubowski <patrick.jakubowski@strongdm.com>
patjakdev
commented
Nov 12, 2024
| } | ||
|
|
||
| func binaryToJSON(dest **binaryJSON, src ast.BinaryNode) { | ||
| n := ast.BinaryNode(src) |
There was a problem hiding this comment.
My editor pointed out that this cast was unnecessary
apg
reviewed
Nov 13, 2024
| @@ -1212,7 +1212,7 @@ func TestPartialBasic(t *testing.T) { | |||
| func TestPartialPanic(t *testing.T) { | |||
| t.Parallel() | |||
| testutil.Panic(t, func() { | |||
| partial(Env{}, nil) | |||
| _, _ = partial(Env{}, nil) | |||
There was a problem hiding this comment.
I'm fine either way, but I think there's a //lint:noerrcheck or something to that effect that is an alternative, here.
There was a problem hiding this comment.
I'm kind of ambivalent as well, so I guess I'll go with the more terse option, especially since this is a test.
apg
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes: See title