Use comparable evaluators in partial evaluation and folding #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For use where the signature of these functions is expected to return an Evaler. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
This ensures that folding works with other types of comparable values, such as datetime, rather than producing an error. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
This ensures that partial evaluation works with other types of comparable values, such as datetime, rather than producing an error. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
All callers have now been switched over to using the more generic comparable value evalers, supporting all comparable types, not just long. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
The error string has changed now that using the comparable value evalers. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes partial evaluation and folding to use the comparable value evaluators in place of the long comparison evaluators. This fixes issues where partial evaluation and folding would produce an error with less than/greater than/less than or equal/greater than or equal comparisons were performed against comparable values other than long (such as datetime).