Allow to use types defined from bool, string, int and int64 as ast Values #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values Signed-off-by: Marcin Swiderski <marcin.swiderski@strongdm.com>
forgems
force-pushed
the
IDX-461-simplify-string
branch
from
5639094 to
200793a
Compare
philhassey
reviewed
Nov 21, 2024
philhassey
approved these changes
Nov 21, 2024
Signed-off-by: Marcin Swiderski <marcin.swiderski@strongdm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #IDX-461
This change will simplify usage of values that underlying type is based on bool, string, int and int64 as Node.
Currently if we have a value of the custom type ex
type CustomBool boolwe have to convert it to bool or types.Boolean first. By adding ~ at type constraints to Boolean, String and Long functions we can use variables of derived type directly without the need of conversion