IDX-470: Change PolicySet.IsAuthorized to take an EntityGetter interface in place of an EntityMap #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a wrapper around the underlying map get, in preparation for introducing an EntityGetter interface. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
This defines an interface for retrieving an Entity by EntityUID, implemented by EntityMap, in preparation for using this in IsAuthorized(). Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
This replaces the concrete EntityMap passed to IsAuthorized() with an EntityGetter interface, allowing alternative implementations of this interface to be supplied for authorization. While this is hypothetically a breaking change, we think that is extremely unlikely to be the case in practice. Any code passing an EntityMap will continue to work - the only potential breakage would be if a caller were directly passing a map[EntityUID]Entity here. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
|
While very unlikely (IMO), this could technically be a breaking change if some existing caller is passing a If we think that risk is too great, we can fall back to the alternative of introducing some new |
|
My only thought is maybe if we add something to the README just noting our definition of non-breaking is that would be nice. Something like:
|
philhassey
approved these changes
Dec 2, 2024
At present time, the maintainers are reserving the right to: * Add variadics to existing functions/methods. * Replace concrete types with interfaces in the parameters to functions/methods (as occurred in this patch set). While strictly breaking changes, we are asserting that the benefits of being able to make changes of these forms without a major revision outweigh the unlikely possibility of breaking code written against cedar-go. We may of course choose to revisit and revise these policies in the future, especially as cedar-go gains wider usage. Signed-off-by: Kevin Jamieson <kevin.jamieson@strongdm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
PolicySetIsAuthorized()method to take anEntityGetterinterface instead of a concreteEntityMapinstance, allowing alternative entity getter implementations to be passed to the authorization.