restructure slice & change instantiation to link
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaobo-he-aws
approved these changes
Jul 2, 2024
|
|
||
| @JsonProperty("templateId") | ||
| private final String templateId; | ||
|
|
||
| @JsonProperty("resultPolicyId") | ||
| private final String resultPolicyId; | ||
|
|
||
| private final List<Instantiation> instantiations; | ||
| @JsonProperty("instantiations") |
There was a problem hiding this comment.
I'm guessing the cedar-policy ffi interface relies on this Json property name and will be renamed in a later change?
mark-creamer-amazon
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #44
Description of changes:
I'm currently working on updating the Java code to match the FFI edits in cedar#1014. This PR pulls out some of the structural changes that I've made locally that aren't specific to the FFI change, with the goal of making future PRs smaller.
slice/folder into dedicated folders (slice/will be deleted as part of the updates for cedar#1014)serializer/folder