Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to match cedar#1014 #173

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Updates to match cedar#1014 #173

merged 8 commits into from
Jul 9, 2024

Conversation

khieta
Copy link
Contributor

@khieta khieta commented Jul 3, 2024

Issue #, if available:

Description of changes:

The promised PR to get the Java bindings working with the upcoming FFI edits in cedar#1014.

Summary:

  • Deletes the Slice class and related classes
  • Adds new custom serializers for PolicySet and TemplateLink
  • Updates the validator to use a PolicySet instead of Set<Policy> (which doesn't support templates or template links)
  • Switches to using EntityUID in LinkValue instead of the (redundant) EntityTypeAndId
  • Removes some (now unused) code from CedarJavaFFI and fixes some warnings

Note: CI failures are expected until cedar#1014 is merged. I plan to merge that PR first.

@khieta khieta marked this pull request as ready for review July 3, 2024 19:48
@khieta
Copy link
Contributor Author

khieta commented Jul 9, 2024

Update: cedar changes have been merged, so this PR is now ready for review 🎉

Copy link
Contributor

@mark-creamer-amazon mark-creamer-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@@ -0,0 +1,43 @@
/*
* Copyright 2022-2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright 2022-2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
* Copyright Cedar Contributors

@khieta khieta merged commit 8de4ac4 into main Jul 9, 2024
4 checks passed
@khieta khieta deleted the khieta/cedar-1014 branch July 9, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants