Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds PolicySet .toJson #283

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Adds PolicySet .toJson #283

wants to merge 5 commits into from

Conversation

muditchaudhary
Copy link
Contributor

@muditchaudhary muditchaudhary commented Jan 24, 2025 •
edited
Loading

Description of Changes

  • Adds .toJson for PolicySet and corresponding FFI functions
  • Adds unit tests for .toJson
  • Changes visibility of CedarJson to public and add modifications to comply with spotbugs
  • Modifies JSONTests to use immutable ObjectReader instead of ObjectMapper for CedarJson

Note:
This change depends on this PR which exposes ffi::PolicySet .parse() in cedar_policy which will be released in the next minor version update of cedar-policy i.e., 4.4.

@muditchaudhary
adds FFI functions for PolicySet.to_json
0f31915 
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
@muditchaudhary
makes CedarJson public and modifies objectMapper getter to return clone
edc6f21 
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
@muditchaudhary
modifies JSONTests to use immutable ObjectReader object instead of Ob…
fd0e40a 
…jectMapper

Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
@muditchaudhary
adds .toJson for PolicySet
62fe294 
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
@muditchaudhary
adds .toJson unit tests for PolicySet and corresponding test utils
19b9b6a 
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
@muditchaudhary muditchaudhary marked this pull request as ready for review January 26, 2025 23:40
@muditchaudhary muditchaudhary marked this pull request as draft January 30, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-creamer-amazon mark-creamer-amazon Awaiting requested review from mark-creamer-amazon

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@muditchaudhary