updates to EST policy set format #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdisselkoen
approved these changes
Jun 21, 2024
Comment on lines
+232
to
+238
| let err = serde_json::from_value::<PolicySet>(json) | ||
| .expect_err("should have failed to parse from JSON"); | ||
| assert_eq!( | ||
| err.to_string(), | ||
| "unknown field `links`, expected one of `templates`, `staticPolicies`, `templateLinks`" | ||
| ); | ||
| } |
There was a problem hiding this comment.
This error is a serde_json::Error rather than one of our internal errors, so no nice miette messaging.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates to the EST policy set format to match the latest JSON FFI design (see #757). Feel free to suggest changes. I don't feel too strongly about field names/structure, just that this interface & the FFI should be consistent.
This is a breaking change for the new JSON policy set format, which is not yet released.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):