Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and flatten frontend #794

Merged
merged 5 commits into from
Apr 19, 2024
Merged

rename and flatten frontend #794

merged 5 commits into from
Apr 19, 2024

Conversation

cdisselkoen
Copy link
Contributor

@cdisselkoen cdisselkoen commented Apr 16, 2024

Description of changes

  • Renames frontend module to ffi
  • Flattens the frontend module. Instead of seeing submodules is_authorized, validate, and utils, everything is exposed in the flat ffi namespace. (Internally we still have separate files for is_authorized, validate, and utils.
  • Also removes the InterfaceResult structure which is dead after 760's changes but for validation APIs #793

Issue #, if available

As suggested in discussion on #757

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen added the breaking-change This is (likely) a breaking change label Apr 16, 2024
@cdisselkoen cdisselkoen requested a review from khieta April 16, 2024 17:22
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@khieta
Copy link
Contributor

khieta commented Apr 16, 2024

Confirming that the current CI failures are expected: downstream DRT code is broken by this PR, downstream Java code is broken by this PR (also currently in a broken state due to #760 and #793), and the semver checks are failing because this PR is indeed a breaking change.

@cdisselkoen cdisselkoen merged commit 91e9f2d into main Apr 19, 2024
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This is (likely) a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants