-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface locations from validation errors, improve TS interfaces #824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My only comment is on two changes:
You changed a pub enum
s variant name, and all the changes from untagged
to tagged(type)
, doesn't this make this a breaking change?
Totally, but cedar-wasm is basically unreleased. People re using it by building directly from source, but it's not officially really released. I don't have strong opinions as to whether it's okay to do this though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
690d650
to
9fb3fa6
Compare
Signed-off-by: Victor Moreno <morevct@amazon.com>
9fb3fa6
to
54fd894
Compare
Heads-up: #800 does want to make breaking changes to some of the choices in this PR. Reviews of #800 are welcome and encouraged.
|
Description of changes
Issue #, if available
806
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):