Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It turns out that if you put
#[serde(rename_all = "camelCase")]
on an enum,serde
doesn't automatically recursively apply the attribute to fields inside enum variants, only to the enum variant names themselves.#814 missed this, and as a result, did not camelCase the
validation_errors
andvalidation_warnings
fields inValidationAnswer
. This PR finishes the job.Our tests in this crate did not catch this because, although they use explicit JSON structures for call inputs (like
ValidationCall
), they do not use explicit JSON structures for call outputs (likeValidationAnswer
), instead relying onserde
to deserialize intoValidationAnswer
and then check that. As a result, the tests are fine with any shape ofValidationAnswer
as long asserde
deserializes it correctly. This PR adds the minimal check thatValidationAnswer
includes fields with the appropriate camelCase names when validation fails.I discovered this when observing that cedar-policy/cedar-java#133 still needed to expect the snake_cased names for these fields. I think we should still merge that PR (which is compatible with #814) and then later as a followup make a new PR compatible with this one.
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)