address review comment - change counter to gauge

ceekay47 · Mar 7, 2024 · 1f6c4a6 · 1f6c4a6
1 parent e2aa3ae
commit 1f6c4a6
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
@@ -27,6 +27,7 @@
 import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
 import org.apache.hadoop.metrics2.lib.MutableCounterInt;
 import org.apache.hadoop.metrics2.lib.MutableCounterLong;
+import org.apache.hadoop.metrics2.lib.MutableGaugeInt;
 
 /**
  * This class is for maintaining Ozone Manager statistics.
@@ -75,7 +76,7 @@ public class OMMetrics implements OmMetadataReaderMetrics {
   private @Metric MutableCounterLong numSnapshotLists;
   private @Metric MutableCounterLong numSnapshotDiffJobs;
   private @Metric MutableCounterLong numSnapshotInfos;
-  private @Metric MutableCounterInt numSnapshotCacheSize;
+  private @Metric MutableGaugeInt numSnapshotCacheSize;
   private @Metric MutableCounterLong numGetFileStatus;
   private @Metric MutableCounterLong numCreateDirectory;
   private @Metric MutableCounterLong numCreateFile;
@@ -531,7 +532,7 @@ public void incNumSnapshotCacheSize() {
   }
 
   public void decNumSnapshotCacheSize() {
-    numSnapshotCacheSize.incr(-1);
+    numSnapshotCacheSize.decr();
   }
 
   public void incNumCompleteMultipartUploadFails() {