Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set remaining model lower limits to zero and make sure demo loop runs with integral approach off #490

Merged
merged 4 commits into from
Aug 19, 2022
Merged

Set remaining model lower limits to zero and make sure demo loop runs with integral approach off #490

merged 4 commits into from
Aug 19, 2022

Conversation

amandalund
Copy link
Contributor

Closes #356.

@amandalund amandalund requested a review from sethrj August 17, 2022 20:37
@amandalund amandalund added the physics Particles, processes, and stepping algorithms label Aug 17, 2022
@amandalund
Move BhabhaEnergyDistribution.hh to em/distribution
d042fc6
@amandalund
Remove second Moller-Bhabha model limit
010e81d 
- Remove MB model min_valid_energy in MollerBhabhaData
- Remove assertion that electron cutoff > model min_valid_energy in MB
  interactor
sethrj
sethrj approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amandalund .

@sethrj sethrj merged commit c769153 into celeritas-project:master Aug 19, 2022
@amandalund amandalund deleted the integral-off branch August 19, 2022 00:24
@amandalund amandalund mentioned this pull request Aug 19, 2022
Closed
@sethrj sethrj added the bug Something isn't working label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working physics Particles, processes, and stepping algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix discrete model selection and model applicability
2 participants
@amandalund @sethrj