Move preprocessor definitions to configuration header #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celerity's list of compile-time feature flags and options has grown considerably over time, and moving them from the command line to a generated header file will keep them more manageable.
Unfortunately we already have the canonical name
config.h
in use for the run-time configuration, so instead of causing confusion with a second file of the same name, I've chosen to move them into our existing generated headerversion.h
. Not perfect for discoerability, but still semantically meaningful as that file enumerates all config options for the particular version of Celerity that's being built.This PR also replaces the somewhat ad-hoc SYCL impl detection macros with a uniform set of
CELERITY_SYCL_IS_*
defines.Also I've made sure all of our own defines are either 0 or 1, never undefined, and added
-Wundef
- this should avoid all future confusion around#if
vs#if defined
.