-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard dependency on psycopg2 #292
Conversation
One would reasonably expect django-celery-results to work with other databases without installing psycopg2. The hard dependency was added in commit 28fb1c6, probably unintentional without fully understanding this aspect.
As a work-around, I have added |
can we add that to this package as well in this PR? |
when is this going to be merged and relased ? |
This PR intends to make the dependency optional. IMO seems a bit odd if a database-agnostic Django app has a dependency on one particular database driver. If there's a need to add MariaDB or Oracle driver-specific logic, will this project also add a dependency for their respective drivers? |
then the dependency should be removed from requirement as well? |
Maybe my PR title was a little misleading. psycopg2 is not currently a declared dependency of the package. So django-celery-results fails with an ImportError, it does not install the psycopg2 package. There's nothing to remove. (The dependency is only in |
what confuses me is the test failures with https://github.com/celery/django-celery-results/pull/294/files |
Thanks for fixing this. I just encountered the issue after an upgrade. Any chance that there will soon be a new pip release including the fix? |
One would reasonably expect django-celery-results to work with other databases without installing psycopg2.
The hard dependency was added in PR #290, probably unintentional without fully understanding this aspect.