-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save extended properties only when asked for #316
save extended properties only when asked for #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need unit tests to cover
@auvipy Thanks for the quick turnaround. Yeah, I am planning to add unit tests for it. Just wanted to be sure that this is the right way to go forward. |
Hey @auvipy, |
Respect extended result flag
@AllexVeldman can you check this please |
Thanks for your review @AllexVeldman, I have addressed the feedback that you have shared. Let me know if there is anything else that you want me to update. |
This pull request introduces 1 alert when merging bde3eef into e174c99 - view on LGTM.com new alerts:
|
cbbe886
to
7edbd42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we document the changes?
@auvipy Can you please guide me on what should be the correct place to document it? |
If you can please dig the docs and find out any suitable place to add, otherwise an entry to changelog would be alright. but I would request to check the docs more initially. |
@auvipy I was actually looking into the docs earlier to figure out if this can be communicated in a better way. Still, the only docs that I came across were these which mention the installation(which points to celery docs), API, and changelog. I think only entry in changelog makes sense here If you have any other place in mind, I would be happy to make the changes there. |
ok put in change log please |
Hey @auvipy, |
this week or week end |
this creates a regression, unless their is a fix, going to revert this |
@auvipy Can you please elaborate the issue? |
new update #326 (comment) |
I guess the change is okay, right? |
seems yeah, need some doc direction most probably |
Could we add a FAQ or something to the docs to inform of this? Maybe even copy the "Getting started" from https://docs.celeryq.dev/en/latest/django/first-steps-with-django.html#django-celery-results-using-the-django-orm-cache-as-a-result-backend and include a note in that? |
please go ahead |
Here you go :) #328 |
Looks like this resolves #142 aka GHSA-fvx8-v524-8579 🎉 |
wow |
Fixes #315
Currently
django-celery-results
stores all the info about the task to DB whereas the default behavior as per celery should only be storing some basic properties. Extended properties should be saved only when they are requested for. It can be done by settingextended-result
flag in the celery config.The PR checks for that flag while storing the results and proceeds accordingly.
I would be adding some tests for it once we are okay with the approach.