chore(isort): switch from isort to ruff
#2234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `isort` with `ruff`: - `ruff` hook has been added to pre-commit - `setup.cfg` configuration disappears in favor of `pyproject.toml` Note that only `I` rule is selected, other linters (flake8, ...) can be migrated in follow-up steps.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
=======================================
Coverage 81.50% 81.51%
=======================================
Files 77 77
Lines 9524 9523 -1
Branches 1152 1152
=======================================
Hits 7763 7763
+ Misses 1569 1568 -1
Partials 192 192 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2232.
This PR replaces
isortwithruff:ruffhook has been added to pre-commitsetup.cfgconfiguration disappears in favor ofpyproject.tomlNote that only
Irule is selected, other linters (flake8, ...) can be migrated in follow-up steps.First commit updates configuration, second commit fixes import formatting to comply with
I001rule.How this has been tested?
Successful
pre-commitjob run: https://github.com/celery/kombu/actions/runs/12990145844/job/36224652021?pr=2234Documentation
As
ruffis installed throughpre-commit, this change should be pretty transparent, however I can mention this change in documentation if needed.