Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: expiration ttl as timedelta on gcpubsub #2240

Closed
wants to merge 2 commits into from
Closed

Conversation

j0j1j2
Copy link

@j0j1j2 j0j1j2 commented Jan 30, 2025

image

With protobuf version 5.29.3, ttl value as string is not supported.

@j0j1j2 j0j1j2 closed this Jan 30, 2025
@auvipy
Copy link
Member

auvipy commented Feb 5, 2025

why the PR was closed?

@j0j1j2
Copy link
Author

j0j1j2 commented Feb 5, 2025

I was using poetry and I met this error with protobuf 5.xx. So I created this PR to fix this error.
but after few minutes later I found that in requirements/extras/gcpubsub.txt, the protobuf version is specified to 4.25.5.
My PR works on protobuf version 5.29.3. but I cannot assure it works on protobuf 4.25.5, So I closed this issue.
If you want to open this again, I'll reopen this PR.

@auvipy
Copy link
Member

auvipy commented Feb 5, 2025

we will need to update the version in future versions

@j0j1j2 j0j1j2 reopened this Feb 5, 2025
@auvipy auvipy closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants