Pin Redis-py version #946
Pin Redis-py version #946
Conversation
Redis-py 3.0.0 was released today and introduced a backwards incompatible changes. https://github.com/andymccurdy/redis-py/blob/9b03af26dc829beea232a3248768de933f4c3b67/CHANGES#L27-L29 This isn't the "best" fix but is the quickest
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 63 63
Lines 6509 6509
Branches 776 776
=======================================
Hits 5771 5771
Misses 656 656
Partials 82 82Continue to review full report at Codecov.
|
|
I think the interface to
I.e. I think
needs to become
|
|
In the mean time what is the chance of getting a quick Kombu release out with this version pin included? |
|
Could it be helpful if I opened a PR that fixes this properly and supports redis-py v2 and v2 concurrently? (Thinking about ease of upgrading for users of celery, who are often not installing kobu directly, or don't do |
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use redis elsewhere. With this change it is possibly worth reverting celery#946
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting celery#946
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting celery#946
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting celery#946
Redis-py 3.0.0 was released today and introduced a backwards incompatible changes.
https://github.com/andymccurdy/redis-py/blob/9b03af26dc829beea232a3248768de933f4c3b67/CHANGES#L27-L29
This isn't the "best" fix but is the quickest.