-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding experimental __slots__ to some classes #368
Conversation
good to see tests are passing |
I want to include it on 5.1 release, may be after christmas or on the new years |
@4383 as far i can recall you use this package on old openstack versions right? would love to have you try this changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any benefit having __slots__
for classes except Message
class. __slots__
is mainly performance related and the only class that is created on bigger scales is Message
class.
IMHO, other classes when used in production, could be also benefited as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am merging this as I can see most of the classes are used by kombu and celery, so in bigger system tiny resource saving would be beneficial, IMHO
will add more slots and fix the issues which break the CI
related celery/vine#67