document memoryview usage, minor frame_writer.write_frame refactor #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at more py-amqp code and found a really interesting usage of
memoryview
inframe_writer
'sbuffer_store
. I added some comments explaining why it's used.I also moved some variables in
frame_writer
'swrite_frame
closer to where they're actually used. Thebuffer_store
isn't used bywrite_frame
when it ends up in theif bigbody:
block, so I moved the code related to thebuffer_store
into theelse:
.