-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance of _get_free_channel_id, fix channel max bug #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also adjust some integration tests as well?
yes |
auvipy
approved these changes
Dec 22, 2021
Hi, can we get a version bump for this fix? Thank you! |
Yes of course, this weekend for sure |
Hi, any update on it? |
Hi, which version has already include this fix? Thank you! |
5.1.1 please |
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
amqp v5.1.0 solved a performance issue of the previous version[1]. [1] celery/py-amqp#385 Change-Id: If9dbbb0e681d6f1c7dca61fe892b10f81f0abb1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a performance issue introduced by #377.
I noticed while running tests that
_get_free_channel_id
is way slower than I expected.Surprisingly, this code that's similar to
_get_free_channel_id
(when all the channel ids are used) takes almost 40 seconds to run:This PR casts
_used_channel_ids
to aset
before the loop, and it only takes ~0.004 seconds to run the loop after this change. It also allows keeping the memory usage improvements by keeping the_used_channel_ids
stored as an array on the class.I also learned that there's a bug preventing
_get_free_channel_id
from reaching thechannel_max
(the limit is currently channel_max - 1), and I fixed that too.