Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove failing docker publish line #62

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Remove failing docker publish line #62

merged 1 commit into from
Jul 7, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Jul 6, 2023 •
edited
Loading

Overview

The docker workflow had a duplicate build and push step that was causing the CI to fail.

This should be applied/verified on rollkit and we should bump the version.

This should close https://github.com/celestiaorg/devops/issues/326

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested a review from a team as a code owner July 6, 2023 18:35
adlerjohn
adlerjohn approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@adlerjohn adlerjohn added the bug Something isn't working label Jul 6, 2023
@rootulp
Copy link
Contributor

rootulp commented Jul 6, 2023

@MSevey does this close https://github.com/celestiaorg/devops/issues/326 ?

@MSevey
Copy link
Member Author

MSevey commented Jul 6, 2023

@MSevey does this close celestiaorg/devops#326 ?

yes I think it should. good catch

@MSevey MSevey enabled auto-merge (squash) July 6, 2023 19:57
Bidon15
Bidon15 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be building images slow again with this PR.

I'll do a very dirty PR next time to avoid slow time due to linux/arm64

cc: @celestiaorg/devops

@MSevey MSevey merged commit 5f647a9 into main Jul 7, 2023
7 checks passed
@MSevey MSevey deleted the MSevey-patch-1 branch July 7, 2023 13:04
MSevey added a commit that referenced this pull request Jul 7, 2023
@MSevey
Revert "Remove failing docker publish line (#62)"
f97d6e3 
This reverts commit 5f647a9.
@MSevey MSevey mentioned this pull request Jul 7, 2023
Merged
@rootulp rootulp mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bidon15 Bidon15 Bidon15 approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

@rootulp rootulp rootulp approved these changes

Assignees

@MSevey MSevey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSevey @rootulp @Bidon15 @adlerjohn