feat: use context - seems like it fixes the ldflags issue #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Bidon15
approved these changes
Jul 10, 2023
github-merge-queue bot
pushed a commit
to celestiaorg/celestia-node
that referenced
this pull request
Jul 12, 2023
hello team! I've created a new version in the common pipeline, this one should fix the issues with the forks and we'll have the version output that we're currently missing when using the docker containers. If this works, we could close the PR: #2421 I've tested on my end and seems to be working 🤞 *PR where we've done the fix*: celestiaorg/.github#65 Thanks in advance! 🚀 Jose Ramon Mañes celestiaorg/devops#370 --------- Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Wondertan
pushed a commit
to celestiaorg/celestia-node
that referenced
this pull request
Jul 12, 2023
hello team! I've created a new version in the common pipeline, this one should fix the issues with the forks and we'll have the version output that we're currently missing when using the docker containers. If this works, we could close the PR: #2421 I've tested on my end and seems to be working crossed_fingers PR where we've done the fix: celestiaorg/.github#65 Thanks in advance! rocket Jose Ramon Mañes celestiaorg/devops#370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello team!
I've added the property
contextto the pipelines due to the issue that we're facing that we lose theldflagsvalues after building the container using GitHub.I've done some different tests, and I realized that if we added this property, we would keep the values and won't need to add the
embedfiles in the repos.Some of the containers tested are:
https://github.com/jrmanes/celestia-node/pkgs/container/celestia-node
https://github.com/jrmanes/.github/commits/main/.github/workflows/reusable_dockerfile_pipeline.yml
Some images:
Celestia-node:
Without using
contextduring build:Using
contextduring build:Celestia-app:
It will report only if it's in a tag, it's okay if we cannot see it, only with tags
I hope this will fix the issue that we're facing atm
Thanks in advance!
Jose Ramon Mañes