Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix github.event_name error #80

Merged
merged 1 commit into from
Oct 12, 2023
Merged

bug: fix github.event_name error #80

merged 1 commit into from
Oct 12, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 12, 2023

Overview

logic was use github.event instead of github.event_name resulting in build_for_pr always being false.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested a review from a team as a code owner October 12, 2023 14:25
@Bidon15 Bidon15 enabled auto-merge (squash) October 12, 2023 14:26
@Bidon15 Bidon15 merged commit f6e5547 into main Oct 12, 2023
8 checks passed
@Bidon15 Bidon15 deleted the sevey/another-fix branch October 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 approved these changes

@Bidon15 Bidon15 Bidon15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSevey @Bidon15 @tty47