Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow to require labels for PRs #108

Closed
rach-id opened this issue Apr 4, 2022 · 2 comments · Fixed by #169
Closed

Add CI workflow to require labels for PRs #108

rach-id opened this issue Apr 4, 2022 · 2 comments · Fixed by #169
Assignees
@rach-id
Labels
github_actions Pull requests that update Github_actions code good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented Apr 4, 2022 •
edited
Loading

As per the discussion in #106 (comment) , we need to add the following workflow to require PRs to have a minimum of 1 label.
@rach-id rach-id added good first issue Good for newcomers github_actions Pull requests that update Github_actions code labels Apr 4, 2022
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 4, 2022
@liamsi
Copy link
Member

liamsi commented Apr 5, 2022 •
edited
Loading

nice, do you mind posting this approach to #engineering? I think we should use this in all repos! (cc @Bidon15 )

@rach-id
Copy link
Member Author

rach-id commented Apr 5, 2022

sure

@liamsi liamsi mentioned this issue Apr 5, 2022
Merged
@rach-id rach-id self-assigned this Aug 3, 2023
@rach-id rach-id removed this from Celestia Node Aug 3, 2023
@rach-id rach-id mentioned this issue Aug 3, 2023
Merged
5 tasks
rach-id added a commit that referenced this issue Aug 4, 2023
@rach-id
ci: add labels workflow (#169)
4d3b39a 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

Closes #108

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
github_actions Pull requests that update Github_actions code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add labels workflow rach-id/quantum-gravity-bridge
2 participants
@liamsi @rach-id