Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests for verifyInner #102

Merged
merged 3 commits into from
Mar 28, 2022
Merged

chore: add tests for verifyInner #102

merged 3 commits into from
Mar 28, 2022

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Mar 28, 2022

Fixes #93

Testing

forge test

Running 15 tests for NamespaceMerkleTreeTest.json:NamespaceMerkleTreeTest
[PASS] testVerifyInnerFalseForIncorrectProofLength() (gas: 1088)
[PASS] testVerifyInnerFalseForStartingHeightZero() (gas: 661)
[PASS] testVerifyInnerFalseForTooLargeKey() (gas: 644)
[PASS] testVerifyInnerLeafIsRoot() (gas: 1183)
...

@rootulp rootulp marked this pull request as ready for review March 28, 2022 18:19
@rootulp rootulp requested a review from adlerjohn as a code owner March 28, 2022 18:19
@adlerjohn adlerjohn requested a review from rach-id March 28, 2022 19:01
rach-id
rach-id approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the test.

ethereum/solidity/src/lib/tree/namespace/NamespaceMerkleTree.sol Outdated Show resolved Hide resolved
ethereum/solidity/src/lib/tree/namespace/NamespaceMerkleTree.sol Outdated Show resolved Hide resolved
rootulp and others added 2 commits March 28, 2022 15:44
@rootulp @rach-id
Update ethereum/solidity/src/lib/tree/namespace/NamespaceMerkleTree.sol
858a4f7 
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@rootulp @rach-id
Update ethereum/solidity/src/lib/tree/namespace/NamespaceMerkleTree.sol
0c906f6 
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@adlerjohn adlerjohn merged commit 4f0d229 into celestiaorg:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees

@rootulp rootulp

Labels
contracts
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more Merkle tree tests
3 participants
@rootulp @adlerjohn @rach-id