Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to Ethereum specifically. #109

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Remove references to Ethereum specifically. #109

merged 2 commits into from
Apr 6, 2022

Conversation

adlerjohn
Copy link
Member

Fixes #107

@adlerjohn adlerjohn added the documentation Improvements or additions to documentation label Apr 5, 2022
@adlerjohn adlerjohn requested review from rach-id and evan-forbes April 5, 2022 21:39
@adlerjohn adlerjohn self-assigned this Apr 5, 2022
rach-id
rach-id approved these changes Apr 6, 2022
View reviewed changes
ethereum/solidity/src/QuantumGravityBridge.sol Outdated Show resolved Hide resolved
rach-id
rach-id reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense also to rename the top folder called ethereum to evm for example?

@adlerjohn @rach-id
Update ethereum/solidity/src/QuantumGravityBridge.sol
306a4ca 
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@adlerjohn
Copy link
Member Author

Does it make sense also to rename the top folder called ethereum to evm for example?

We can just move everything up one level once we remove the orchestrator code.

@adlerjohn adlerjohn merged commit 6a3cea3 into master Apr 6, 2022
@adlerjohn adlerjohn deleted the adlerjohn/remove-remove-ref-ethereum branch April 6, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@adlerjohn adlerjohn

Labels
documentation Improvements or additions to documentation
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify EVM-compability of contract
2 participants
@adlerjohn @rach-id