Universal nonce #119
Universal nonce #119
Conversation
| /// @param _dataRootTupleRoot The Merkle root of data root tuples. | ||
| /// @param _currentValidatorSet The current validator set. | ||
| /// @param _sigs Signatures. | ||
| function submitDataRootTupleRoot( | ||
| uint256 _nonce, | ||
| uint256 _newNonce, | ||
| uint256 _validatorSetNonce, |
There was a problem hiding this comment.
Rather than passing in the latest validator set nonce as a parameter, this could be saved in storage. Opinions either way @evan-forbes @sweexordious?
There was a problem hiding this comment.
same. How much gas would that cost? It would only save a few queries for the relayer, and not that many people will be running relayers I don't think, so probably not worth it add storage me thinks.
There was a problem hiding this comment.
It would be more expensive in every way to use storage.
| /// @param _dataRootTupleRoot The Merkle root of data root tuples. | ||
| /// @param _currentValidatorSet The current validator set. | ||
| /// @param _sigs Signatures. | ||
| function submitDataRootTupleRoot( | ||
| uint256 _nonce, | ||
| uint256 _newNonce, | ||
| uint256 _validatorSetNonce, |
There was a problem hiding this comment.
linking to celestiaorg/celestia-app#464 again for posterity
LGTM 👍
| /// @param _dataRootTupleRoot The Merkle root of data root tuples. | ||
| /// @param _currentValidatorSet The current validator set. | ||
| /// @param _sigs Signatures. | ||
| function submitDataRootTupleRoot( | ||
| uint256 _nonce, | ||
| uint256 _newNonce, | ||
| uint256 _validatorSetNonce, |
There was a problem hiding this comment.
same. How much gas would that cost? It would only save a few queries for the relayer, and not that many people will be running relayers I don't think, so probably not worth it add storage me thinks.
Fixes #118