Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 0.8.19 #323

Closed
wants to merge 1 commit into from
Closed

use 0.8.19 #323

wants to merge 1 commit into from

Conversation

Ferret-san
Copy link

@Ferret-san Ferret-san commented Jul 2, 2024

Summary by CodeRabbit

  • Refactor
    • Downgraded Solidity compiler version from 0.8.22 to 0.8.19 across various files to ensure compatibility and maintainability.
    • Improved code readability by reformatting function parameters and event definitions.

Copy link

coderabbitai bot commented Jul 2, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

This update primarily involves downgrading the Solidity compiler version from 0.8.22 to 0.8.19 across various configurations and source files. Additionally, numerous formatting improvements were made for better code readability and maintainability without altering the actual logic or functionality of the contracts and scripts.

Changes

Files Change Summary
foundry.toml, hardhat.config.ts, scripts/Dockerfile_Environment Downgraded Solidity compiler version from 0.8.22 to 0.8.19.
src/Blobstream.sol, src/Constants.sol, src/DataRootTuple.sol Downgraded Solidity pragma version and made various formatting updates for better readability.
src/lib/tree/.../*.sol, src/lib/verifier/DAVerifier.sol Updated Solidity pragma version and reformatted function parameter lists and code blocks for improved readability.
src/test/Blobstream.t.sol, src/lib/tree/binary/test/.../*.t.sol Changed Solidity version pragma and reformatted function arguments and code blocks for clarity and maintainability.

Sequence Diagram(s)

Changes are primarily version downgrades and formatting updates, which don't significantly impact control flow or features, so sequence diagrams are not provided.

Poem

🐇✨
In code we trust, a seamless flight,
Downgrade done, all set aright.
Solidity's old charm in lines anew,
Together we'll build and proudly view.
Debug less, create with flair,
For every bunny coder, everywhere!
✨🐇


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -1,4 +1,4 @@
[profile.default]
solc_version = "0.8.22"
solc_version = "0.8.19"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not downgrade the version of the compiler, only the contracts. Also, would need to investigate the optimisations that we removed because they're applied automatically in the new solidity version, whether we need to re-introduce them.

also, would be good to have more information on why this change is needed

@@ -36,7 +36,12 @@ struct Signature {
/// block headers.
/// @dev DO NOT REMOVE INHERITANCE OF THE FOLLOWING CONTRACTS: Initializable, UUPSUpgradeable and
/// OwnableUpgradeable! They're essential for upgradability.
contract Blobstream is IDAOracle, Initializable, UUPSUpgradeable, OwnableUpgradeable {
contract Blobstream is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not format and downgrade the version in the same PR.

Also, which formatter did you use to have all of these changes? ideally, we have that in the CI to enforce a certain formatting.

@Ferret-san
Copy link
Author

ah mb @rach-id, I accidentally opened this branch against main and not my own fork. Plz feel free to ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants