-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 0.8.19 #323
use 0.8.19 #323
Conversation
Warning Review failedThe pull request is closed. WalkthroughThis update primarily involves downgrading the Solidity compiler version from Changes
Sequence Diagram(s)Changes are primarily version downgrades and formatting updates, which don't significantly impact control flow or features, so sequence diagrams are not provided. Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -1,4 +1,4 @@ | |||
[profile.default] | |||
solc_version = "0.8.22" | |||
solc_version = "0.8.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not downgrade the version of the compiler, only the contracts. Also, would need to investigate the optimisations that we removed because they're applied automatically in the new solidity version, whether we need to re-introduce them.
also, would be good to have more information on why this change is needed
@@ -36,7 +36,12 @@ struct Signature { | |||
/// block headers. | |||
/// @dev DO NOT REMOVE INHERITANCE OF THE FOLLOWING CONTRACTS: Initializable, UUPSUpgradeable and | |||
/// OwnableUpgradeable! They're essential for upgradability. | |||
contract Blobstream is IDAOracle, Initializable, UUPSUpgradeable, OwnableUpgradeable { | |||
contract Blobstream is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not format and downgrade the version in the same PR.
Also, which formatter did you use to have all of these changes? ideally, we have that in the CI to enforce a certain formatting.
ah mb @rach-id, I accidentally opened this branch against main and not my own fork. Plz feel free to ignore |
Summary by CodeRabbit