Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use Foundry and add Merkle tree tests #51

Merged
merged 32 commits into from
Mar 7, 2022
Merged

feat: Use Foundry and add Merkle tree tests #51

merged 32 commits into from
Mar 7, 2022

Conversation

adlerjohn
Copy link
Member

@adlerjohn adlerjohn commented Feb 6, 2022 •
edited
Loading

Use Foundry instead of Hardhat, and add tests for the Merkle trees.

Note that CI isn't set up yet to run these tests, so you'll need to install Foundry then run forge test. #59 tracks adding contract tests to CI.

Also fixes two bugs

  1. f76eef0 (which is actually a bug upstream, and was fixed there in tandem)
  2. 32de73c

@adlerjohn adlerjohn self-assigned this Feb 6, 2022
@adlerjohn adlerjohn changed the base branch from master to adlerjohn/libraries February 6, 2022 18:43
@adlerjohn adlerjohn changed the title Use Foundry and add Merkle tree tests feat: Use Foundry and add Merkle tree tests Feb 6, 2022
@adlerjohn adlerjohn mentioned this pull request Feb 25, 2022
Merged
4 tasks
@adlerjohn adlerjohn marked this pull request as ready for review February 25, 2022 21:14
@adlerjohn adlerjohn requested a review from liamsi as a code owner February 25, 2022 21:14
liamsi
liamsi reviewed Feb 27, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was first shocked when I saw "Files changed 163" but it's mostly renaming. Will review the tests shortly.

@adlerjohn adlerjohn added bug Something isn't working enhancement New feature or request labels Mar 5, 2022
Base automatically changed from adlerjohn/libraries to master March 7, 2022 18:37
@adlerjohn adlerjohn merged commit 329a61c into master Mar 7, 2022
@adlerjohn adlerjohn deleted the adlerjohn/foundry branch March 7, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi left review comments

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@adlerjohn adlerjohn

Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adlerjohn @liamsi @rach-id