Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use minimum solc v0.8.4 #70

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

adlerjohn
Copy link
Member

Fixes #43

@adlerjohn adlerjohn requested review from rach-id and evan-forbes March 8, 2022 17:50
@adlerjohn adlerjohn self-assigned this Mar 8, 2022
@adlerjohn adlerjohn changed the title Use minimum solc v0.8.4 fix: Use minimum solc v0.8.4 Mar 8, 2022
@rach-id rach-id closed this Mar 8, 2022
@rach-id rach-id deleted the adlerjohn/solc-min-v0.8.4 branch March 8, 2022 18:55
@rach-id rach-id restored the adlerjohn/solc-min-v0.8.4 branch March 8, 2022 18:57
@rach-id rach-id reopened this Mar 8, 2022
@rach-id
Copy link
Member

rach-id commented Mar 8, 2022

Sorry :D

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One question, why not update the version to even more recent versions ? 0.8.11 for example or 0.8.12 ?

@adlerjohn
Copy link
Member Author

why not update the version to even more recent versions?

If there's no need for new features, keeping the lowest possible version means more compiler versions can be used. That's about it.

@adlerjohn adlerjohn merged commit eb52842 into master Mar 8, 2022
@adlerjohn adlerjohn deleted the adlerjohn/solc-min-v0.8.4 branch March 8, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change minimum Solidity version to 0.8.4
2 participants