Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Regenerate contract ABI bindings. #76

Merged
merged 3 commits into from
Mar 10, 2022
Merged

chore: Regenerate contract ABI bindings. #76

merged 3 commits into from
Mar 10, 2022

Conversation

adlerjohn
Copy link
Member

Fixes #64

@adlerjohn adlerjohn self-assigned this Mar 10, 2022
@adlerjohn adlerjohn changed the title Regenerate contract ABI bindings. chore: Regenerate contract ABI bindings. Mar 10, 2022
@adlerjohn adlerjohn marked this pull request as ready for review March 10, 2022 15:46
@adlerjohn
Copy link
Member Author

CI is expected to fail since the contract ABI is completely different, but not sure if it's supposed to fail as it did.

@evan-forbes
Copy link
Member

yeah, me either. That test is running using umee, so not sure it's doing any good anywho.

https://github.com/celestiaorg/quantum-gravity-bridge/blob/9794ddbaefc937c76e4f28bbc4ea5d35db835636/test/run-gh-tests.sh#L10

We definitely need similar integration tests tho celestiaorg/celestia-app#324

evan-forbes
evan-forbes approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it up you on whether to delete comment out that test in this PR or not. The MVP orchestrator and relayer are blocked by these bindings, so approving

@adlerjohn adlerjohn requested a review from evan-forbes March 10, 2022 16:25
evan-forbes
evan-forbes approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again! we can remove the unused code the linter is pointing out later imho

@adlerjohn adlerjohn merged commit be079fc into master Mar 10, 2022
@adlerjohn adlerjohn deleted the adlerjohn/regenerate-abi branch March 10, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rach-id rach-id Awaiting requested review from rach-id rach-id is a code owner

Assignees

@adlerjohn adlerjohn

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-generate contract ABI
2 participants
@adlerjohn @evan-forbes